search

aws / aws-cdk

The AWS Cloud Development Kit is a framework for defining cloud infrastructure in code
https://aws.amazon.com/cdk
Apache License 2.0
11.68k stars 3.93k forks source link

fix(ec2): fixing vpc endpoint pattern for ecr and ecr docker #31434

Closed shikha372 closed 2 months ago

shikha372 commented 2 months ago

Issue # (if applicable)

Closes #. Internal Tracking ticket P150271569

Reason for this change

Expected Endpoints for ECR in some isolated regions are as below

gov.ic.hci.csp.us-isof-name.ecr.api, gov.ic.hci.csp.us-isof-name.ecr.dkr, uk.adc-e.cloud.eu-isoe-name.ecr.api, uk.adc-e.cloud.eu-isoe-name.ecr.dkr,

Description of changes

As discussed with the ECR Service team, endpoints for the service are being generated in reverse order of the domain suffix. Since some of the endpoints for other services are still using com.amazonaws , added fix only for the partitions and service(ECR) flagged.

Cannot do for cn regions on the basis of suffix as both regions have different services under exceptions.

Description of how you validated changes

Added unit test for validation of endpoint, keeping the region names as us-isoe-test-1 as the regions are in build stage and could be confidential.

No changes to integration test as the fix is for isolated regions.

Checklist

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

shikha372 commented 2 months ago

Exemption Request : No changes to integration test as the fix is for isolated regions.

mergify[bot] commented 2 months ago

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

aws-cdk-automation commented 2 months ago

AWS CodeBuild CI Report

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mergify[bot] commented 2 months ago

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

github-actions[bot] commented 2 months ago

Comments on closed issues and PRs are hard for our team to see. If you need help, please open a new issue that references this one.