search

aws / aws-cdk

The AWS Cloud Development Kit is a framework for defining cloud infrastructure in code
https://aws.amazon.com/cdk
Apache License 2.0
11.55k stars 3.87k forks source link

feat(events-target): support Dead Letter Queue for Kinesis Stream Event Target #31435

Closed mazyu36 closed 2 weeks ago

mazyu36 commented 2 weeks ago

Issue # (if applicable)

Closes #31428.

Reason for this change

Kinesis Stream Event Target supports Dead Letter Queue (DLQ). But current KinesisStream class in events-target does not support it.

Description of changes

Modified KinesisStreamProps to extend TargetBaseProps, enabling the configuration of DLQ and retry policy.

This change has also been applied to other resources in #13600.

Description of how you validated changes

Add a unit test and an integ test.

Checklist

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

aws-cdk-automation commented 2 weeks ago

AWS CodeBuild CI Report

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mergify[bot] commented 2 weeks ago

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

github-actions[bot] commented 2 weeks ago

Comments on closed issues and PRs are hard for our team to see. If you need help, please open a new issue that references this one.