chore(s3): readme update with mixing L1 and L2 bucket policy

aws / aws-cdk

The AWS Cloud Development Kit is a framework for defining cloud infrastructure in code

https://aws.amazon.com/cdk

Apache License 2.0

11.68k stars 3.93k forks source link

chore(s3): readme update with mixing L1 and L2 bucket policy #31437

Closed GavinZZ closed 2 months ago

GavinZZ commented 2 months ago

Issue # (if applicable)

Closes https://github.com/aws/aws-cdk/issues/30148

Reason for this change

Users using L1 and L2 bucket policy with serverAccessLogsBucket would cause bucket policy overwrite instead of append.

Description of changes

No behavioural change, only readme update to explain the issues and the workaround.

Description of how you validated changes

No behavioural change.

Checklist

[ ] My code adheres to the CONTRIBUTING GUIDE and DESIGN GUIDELINES

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

mergify[bot] commented 2 months ago

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

aws-cdk-automation commented 2 months ago

AWS CodeBuild CI Report

CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
Commit ID: 33f2836df7559b1808926b61ea6220d8943a1d71
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mergify[bot] commented 2 months ago

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

github-actions[bot] commented 2 months ago

Comments on closed issues and PRs are hard for our team to see. If you need help, please open a new issue that references this one.