aws / aws-cdk

The AWS Cloud Development Kit is a framework for defining cloud infrastructure in code
https://aws.amazon.com/cdk
Apache License 2.0
11.55k stars 3.87k forks source link

chore(ec2): invalid Interface VPC Endpoints #31441

Closed badmintoncryer closed 1 week ago

badmintoncryer commented 2 weeks ago

Issue # (if applicable)

None

Reason for this change

The wrong URLs were set for several Interface Endpoints, so I corrected them.

For example, when retrieving the freetier endpoint via CLI, it shows as aws.api.{region}.freetier, but in CDK, it was set to com.amazonaws.{region}.freetire.

I believe this correction might be a breaking change, but since the previous URLs likely wouldn't have allowed access anyway, I'm unsure how to proceed. Which of the following approaches would be best?

Description of changes

Update URL from com.amazonaws.{region}.{service} to aws.api.{region}.{service}

Description of how you validated changes

I've executed described-vpc-endpoint-services CLI.

❯ aws ec2 describe-vpc-endpoint-services --filters Name=service-type,Values=Interface Name=owner,Values=amazon --region us-east-1 --query ServiceNames | grep aws.api
    "aws.api.us-east-1.bcm-data-exports",
    "aws.api.us-east-1.freetier",
    "aws.api.us-east-1.kendra-ranking",
    "aws.api.us-east-1.qbusiness",

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

badmintoncryer commented 2 weeks ago

exemption request I don't think this PR requires updates to the README or test files.

mergify[bot] commented 1 week ago

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

badmintoncryer commented 1 week ago

@mergify update

mergify[bot] commented 1 week ago

update

❌ Mergify doesn't have permission to update

For security reasons, Mergify can't update this pull request. Try updating locally. GitHub response: refusing to allow a GitHub App to create or update workflow `.github/workflows/github-merit-badger.yml` without `workflows` permission
badmintoncryer commented 1 week ago

@mergify update

mergify[bot] commented 1 week ago

update

❌ Mergify doesn't have permission to update

For security reasons, Mergify can't update this pull request. Try updating locally. GitHub response: refusing to allow a GitHub App to create or update workflow `.github/workflows/github-merit-badger.yml` without `workflows` permission
badmintoncryer commented 1 week ago

@mergify update

mergify[bot] commented 1 week ago

update

✅ Branch has been successfully updated

badmintoncryer commented 1 week ago

@mergifyio update

mergify[bot] commented 1 week ago

update

☑️ Nothing to do

- [ ] `#commits-behind > 0` [📌 update requirement] - [X] `-closed` [📌 update requirement] - [X] `-conflict` [📌 update requirement] - [X] `queue-position = -1` [📌 update requirement]
badmintoncryer commented 1 week ago

@mergifyio refresh

mergify[bot] commented 1 week ago

refresh

✅ Pull request refreshed

mergify[bot] commented 1 week ago

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

aws-cdk-automation commented 1 week ago

AWS CodeBuild CI Report

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mergify[bot] commented 1 week ago

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

github-actions[bot] commented 1 week ago

Comments on closed issues and PRs are hard for our team to see. If you need help, please open a new issue that references this one.