feat(eks): update nodegroup gpu check

aws / aws-cdk

The AWS Cloud Development Kit is a framework for defining cloud infrastructure in code

https://aws.amazon.com/cdk

Apache License 2.0

11.68k stars 3.93k forks source link

feat(eks): update nodegroup gpu check #31445

Open AlexKaracaoglu opened 2 months ago

AlexKaracaoglu commented 2 months ago

Issue # (if applicable)

Closes #31347.

Reason for this change

The motivating bug is that you cannot add a combo of g5 and a g6 as instance classes onto the same node group or else the following error will be thrown: instanceTypes of different architectures is not allowed.

Description of changes

(eks) Fixes the isGpuInstanceType check
- G6/G6E instance classes will now be recognized as GPU instance types so those different types can be used together for a multi instance type managed node group

Description of how you validated changes

Wrote unit tests for the isGpuInstanceType function

Checklist

[x] My code adheres to the CONTRIBUTING GUIDE and DESIGN GUIDELINES

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

pahud commented 1 month ago

Hi @AlexKaracaoglu

Not sure if you are still on it but you can refer to this commit I made https://github.com/pahud/aws-cdk/commit/8fd3db823e232e87b010f990f009b8b22aade093

AlexKaracaoglu commented 1 month ago

@pahud @sumupitchayan - Appreciate the follow ups, I'll get some changes in later today

aws-cdk-automation commented 1 month ago

AWS CodeBuild CI Report

CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
Commit ID: 7f82fd51a6e0b447ff7036039de669ccb25a0035
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-cdk-automation commented 1 week ago

The pull request linter fails with the following errors:

❌ Features must contain a change to a README file.
❌ Features must contain a change to an integration test file and the resulting snapshot.

PRs must pass status checks before we can provide a meaningful review.

If you would like to request an exemption from the status checks or clarification on feedback, please leave a comment on this PR containing Exemption Request and/or Clarification Request.