aws / aws-cdk

The AWS Cloud Development Kit is a framework for defining cloud infrastructure in code
https://aws.amazon.com/cdk
Apache License 2.0
11.68k stars 3.93k forks source link

chore(vpcv2): fix doc issue due to IRoute #31464

Closed shikha372 closed 1 month ago

shikha372 commented 2 months ago

Issue # (if applicable)

Closes #NA.

Reason for this change

Fixes the doc job build failure for python docs failing with the error in main pipeline

TypeError: Cannot create a consistent method resolution
order (MRO) for bases IConstruct, IResource, Protocol

Issue seemed to have been occured due to IRoute interface extending both IConstruct and IResource, we don't need it as IResource already extends IConstruct and IConstruct extends IDependable.

Description of changes

Renamed IRoute to IRouteV2(as previous release) , we already have an interface in the main lib with name IRoute for apigateway

Description of how you validated changes

Deployed in test-pipeline for verification using

git fetch origin pull/31464/head
git push -f origin FETCH_HEAD:test-main-pipeline

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

aws-cdk-automation commented 1 month ago

AWS CodeBuild CI Report

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mergify[bot] commented 1 month ago

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

shikha372 commented 1 month ago

@mergifyio update

mergify[bot] commented 1 month ago

update

☑️ Nothing to do

- [ ] `#commits-behind > 0` [📌 update requirement] - [X] `-closed` [📌 update requirement] - [X] `-conflict` [📌 update requirement] - [X] `queue-position = -1` [📌 update requirement]
github-actions[bot] commented 1 month ago

Comments on closed issues and PRs are hard for our team to see. If you need help, please open a new issue that references this one.