Closed comcalvi closed 1 month ago
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).
Comments on closed issues and PRs are hard for our team to see. If you need help, please open a new issue that references this one.
Issue # (if applicable)
Closes #31345.
Reason for this change
Any stringified value containing an intrinsic will use a custom resource to resolve this value at deploy time.
Today, this custom resource's logical ID will take the form is a counter incremented for each stringified value. This results in resource replacement updates for the custom resource when the order of construct instantiation is changed, like changing this:
'CDKJsonStringify<number>'
, whereto:
This only happens if
SomeStack
stringifies a token, which some CDK constructs will do automatically. These resource replacements won't affect customer infrastructure, but customers using a common setup as in #31345 will see diffs on the same application in different environments, which violates the repeatability promise of CDK.Description of changes
Generate a unique identifier from the token's value instead of a counter. This makes this logical ID no longer instantiation-order dependent.
This will cause diffs when upgrading.
Description of how you validated changes
Unit, integration, and manual tests.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license