feat(rds): support for local write forwarding in an Aurora Mysql cluster

aws / aws-cdk

The AWS Cloud Development Kit is a framework for defining cloud infrastructure in code

https://aws.amazon.com/cdk

Apache License 2.0

11.55k stars 3.87k forks source link

feat(rds): support for local write forwarding in an Aurora Mysql cluster #31524

Closed badmintoncryer closed 2 days ago

badmintoncryer commented 5 days ago

Issue # (if applicable)

Closes #31523 .

Reason for this change

Cloudformation supports enabling local write forwarding feature but AWS CDK does not support it.

Description of changes

Add enableLocalWriteForwarding to DatabaseClusterBaseProps
Add validation that engineType is either aurora or aurora-mysql
- Having engineType set to aurora means launching a MySQL-compatible Aurora cluster.

Description of how you validated changes

Add both unit and integ tests.

Checklist

[x] My code adheres to the CONTRIBUTING GUIDE and DESIGN GUIDELINES

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

badmintoncryer commented 5 days ago

@go-to-k Thank you for your review!

Then I got an error even though it was false.

This result was also something I did not anticipate. The validation using !== undefined was not intended to account for this but happened by chance.

I added a case to the unit test to verify that an error occurs even when false is passed!

go-to-k commented 5 days ago

It might be good to add a code comment at the conditional branch that says that a CFn error will occur not only when the property is true but also when false, if the engine type is not mysql. Otherwise developers might get confused.

badmintoncryer commented 4 days ago

@go-to-k I have updated the description!

mergify[bot] commented 2 days ago

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

aws-cdk-automation commented 2 days ago

AWS CodeBuild CI Report

CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
Commit ID: 8db1fef6604fca7c825b356d3dd4bf4d9d3e7926
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mergify[bot] commented 2 days ago

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

github-actions[bot] commented 2 days ago

Comments on closed issues and PRs are hard for our team to see. If you need help, please open a new issue that references this one.