search

aws / aws-cdk

The AWS Cloud Development Kit is a framework for defining cloud infrastructure in code
https://aws.amazon.com/cdk
Apache License 2.0
11.62k stars 3.91k forks source link

community review workflow stuck with `Action Required` state #31870

Open tmokmss opened 1 day ago

tmokmss commented 1 day ago

Describe the bug

Hi, apparently the community review workflow is not working now. It seems an approval from a maintainer is required to run the PR linter workflow. PR: https://github.com/aws/aws-cdk/pull/31212

These runs are left pending since yesterday: #1, #2

Can someone from the core team approve the workflow execution? Also, do we need the approval for each PR?

Regression Issue

Last Known Working CDK Version

No response

Expected Behavior

PR linter workflow runs and if there is an approval review, a tag (pr/needs-maintainer-review) is added. As described here.

Current Behavior

PR linter workflow stuck with pending approval.

Reproduction Steps

leave a community review to a PR.

Possible Solution

No response

Additional Information/Context

No response

CDK CLI Version

2.163.1

Framework Version

No response

Node.js Version

20

OS

macos

Language

TypeScript

Language Version

No response

Other information

No response

khushail commented 10 hours ago

Hi @tmokmss ,thanks for reporting this. 

Can someone from the core team approve the workflow execution? Also, do we need the approval for each PR?

AFAIK, approval for each PR is not needed.

Reaching out to core team, requesting their inputs and action.

khushail commented 10 hours ago

@tmokmss , got to know from the team that they are aware of this issue and already working towards its resolution.

I would be moving this issue to team's project board for visibility and further action.

Appreciate you having patience here !