aws / aws-cdk

The AWS Cloud Development Kit is a framework for defining cloud infrastructure in code
https://aws.amazon.com/cdk
Apache License 2.0
11.68k stars 3.93k forks source link

chore(ec2): pricing api interface vpc endpoint duplicated #31912

Closed mazyu36 closed 3 weeks ago

mazyu36 commented 3 weeks ago

Issue # (if applicable)

Closes #31911.

Reason for this change

InterfaceVpcEndpointAwsService('pricing.api') enum duplicated.

https://github.com/aws/aws-cdk/blob/main/packages/aws-cdk-lib/aws-ec2/lib/vpc-endpoint.ts#L518 https://github.com/aws/aws-cdk/blob/main/packages/aws-cdk-lib/aws-ec2/lib/vpc-endpoint.ts#L520

One side should be deleted.

Description of changes

Delete the enum that was added later.

Description of how you validated changes

nothing because only enum changed

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

mazyu36 commented 3 weeks ago

Exemption Request: No testing needed as only enum was changed.

mergify[bot] commented 3 weeks ago

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

aws-cdk-automation commented 3 weeks ago

AWS CodeBuild CI Report

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mergify[bot] commented 3 weeks ago

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

github-actions[bot] commented 3 weeks ago

Comments on closed issues and PRs are hard for our team to see. If you need help, please open a new issue that references this one.