chore(cli): add image to gc docs and document race condition

aws / aws-cdk

The AWS Cloud Development Kit is a framework for defining cloud infrastructure in code

https://aws.amazon.com/cdk

Apache License 2.0

11.68k stars 3.93k forks source link

chore(cli): add image to gc docs and document race condition #31925

Closed kaizencc closed 2 weeks ago

kaizencc commented 2 weeks ago

This might be contentious given that we don't do photos in most places but afaik we do not replicate the CLI docs on the CDK docs site so it may be safe (as it renders correctly on github).

Documents garbage collection algorithm via diagram and details potentail race condition with REVIEW_IN_PROGRESS stacks.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

aws-cdk-automation commented 2 weeks ago

AWS CodeBuild CI Report

CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
Commit ID: 1a07e72351476047023b8bd2a5b93ba6376a8d36
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mergify[bot] commented 2 weeks ago

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

github-actions[bot] commented 2 weeks ago

Comments on closed issues and PRs are hard for our team to see. If you need help, please open a new issue that references this one.