search

aws / aws-cdk

The AWS Cloud Development Kit is a framework for defining cloud infrastructure in code
https://aws.amazon.com/cdk
Apache License 2.0
11.68k stars 3.93k forks source link

revert: feat(cdk): update tsconfig to more modern settings in typescript init templates #31953

Closed xazhao closed 2 weeks ago

xazhao commented 2 weeks ago

This reverts https://github.com/aws/aws-cdk/pull/31927

There are some TypeScript init tests failed. Revert the change for now so that it doesn't block the release.

Will investigate why those test failed.

Issue # (if applicable)

Closes #.

Reason for this change

Description of changes

Description of how you validated changes

Checklist

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

mrgrain commented 2 weeks ago

@ren-yamanashi Apologies, I missed the required update to tests, hence the revert. I will re roll this with the correct updates.

mergify[bot] commented 2 weeks ago

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

aws-cdk-automation commented 2 weeks ago

AWS CodeBuild CI Report

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mergify[bot] commented 2 weeks ago

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

github-actions[bot] commented 2 weeks ago

Comments on closed issues and PRs are hard for our team to see. If you need help, please open a new issue that references this one.