aws / aws-cdk

The AWS Cloud Development Kit is a framework for defining cloud infrastructure in code
https://aws.amazon.com/cdk
Apache License 2.0
11.68k stars 3.93k forks source link

chore: exclude some `logs-monitor` code from coverage #32107

Closed iliapolo closed 2 days ago

iliapolo commented 2 days ago

Code that may or may not run should be excluded from coverage.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

iliapolo commented 2 days ago

Currently affecting this PR: https://github.com/aws/aws-cdk/pull/29458

codecov[bot] commented 2 days ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 77.30%. Comparing base (b763d86) to head (ed0175a). Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #32107 +/- ## ========================================== - Coverage 77.30% 77.30% -0.01% ========================================== Files 114 114 Lines 7628 7627 -1 Branches 1360 1360 ========================================== - Hits 5897 5896 -1 Misses 1549 1549 Partials 182 182 ``` | [Flag](https://app.codecov.io/gh/aws/aws-cdk/pull/32107/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aws) | Coverage Δ | | |---|---|---| | [suite.unit](https://app.codecov.io/gh/aws/aws-cdk/pull/32107/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aws) | `77.30% <ø> (-0.01%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aws#carryforward-flags-in-the-pull-request-comment) to find out more. | [Components](https://app.codecov.io/gh/aws/aws-cdk/pull/32107/components?src=pr&el=components&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aws) | Coverage Δ | | |---|---|---| | [packages/aws-cdk](https://app.codecov.io/gh/aws/aws-cdk/pull/32107/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aws) | `77.30% <ø> (-0.01%)` | :arrow_down: |
aws-cdk-automation commented 2 days ago

AWS CodeBuild CI Report

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mergify[bot] commented 2 days ago

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

github-actions[bot] commented 2 days ago

Comments on closed issues and PRs are hard for our team to see. If you need help, please open a new issue that references this one.