aws / aws-cdk

The AWS Cloud Development Kit is a framework for defining cloud infrastructure in code
https://aws.amazon.com/cdk
Apache License 2.0
11.68k stars 3.93k forks source link

chore: disable codecov from `v2-release` branch #32125

Closed iliapolo closed 1 day ago

iliapolo commented 1 day ago

In https://github.com/aws/aws-cdk/pull/32082, we added codecov checks to mergify merge conditions.

This, as originally intended, blocked merging to both the main and the v2-release branches. However, we decided that currently we won't be applying codecov on the v2-release branch because it is redundant.

Ideally, to achieve this, we would remove the conditions only from the mergify configuration that applies to the v2-release branch. But our configuration isn't set up that way right now, it doesn't distinguish between branches.

Luckily, mergify will automatically honor branch protection rules, so we can safely remove the branch dependant conditions from mergify all together, and keep them only in branch protection rules (which we already configured).

Once this PR is merged, I will also remove the codecov branch protection from v2-release (but keep it on main).

Additional Changes

There's some additional codecov related cleanup we need to do so might as well. They are explained as review comments.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

codecov[bot] commented 1 day ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 77.14%. Comparing base (588f1f6) to head (39369c4). Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #32125 +/- ## ========================================== - Coverage 77.29% 77.14% -0.15% ========================================== Files 114 105 -9 Lines 7627 7163 -464 Branches 1360 1311 -49 ========================================== - Hits 5895 5526 -369 + Misses 1550 1457 -93 + Partials 182 180 -2 ``` | [Flag](https://app.codecov.io/gh/aws/aws-cdk/pull/32125/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aws) | Coverage Δ | | |---|---|---| | [suite.unit](https://app.codecov.io/gh/aws/aws-cdk/pull/32125/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aws) | `77.14% <ø> (-0.15%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aws#carryforward-flags-in-the-pull-request-comment) to find out more. | [Components](https://app.codecov.io/gh/aws/aws-cdk/pull/32125/components?src=pr&el=components&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aws) | Coverage Δ | | |---|---|---| | [packages/aws-cdk](https://app.codecov.io/gh/aws/aws-cdk/pull/32125/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aws) | `77.14% <ø> (-0.15%)` | :arrow_down: |
aws-cdk-automation commented 1 day ago

AWS CodeBuild CI Report

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

github-actions[bot] commented 1 day ago

Comments on closed issues and PRs are hard for our team to see. If you need help, please open a new issue that references this one.