Closed iliapolo closed 1 day ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 77.14%. Comparing base (
588f1f6
) to head (39369c4
). Report is 1 commits behind head on main.
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
Comments on closed issues and PRs are hard for our team to see. If you need help, please open a new issue that references this one.
In https://github.com/aws/aws-cdk/pull/32082, we added codecov checks to mergify merge conditions.
This, as originally intended, blocked merging to both the
main
and thev2-release
branches. However, we decided that currently we won't be applying codecov on thev2-release
branch because it is redundant.Ideally, to achieve this, we would remove the conditions only from the mergify configuration that applies to the
v2-release
branch. But our configuration isn't set up that way right now, it doesn't distinguish between branches.Luckily, mergify will automatically honor branch protection rules, so we can safely remove the branch dependant conditions from mergify all together, and keep them only in branch protection rules (which we already configured).
Once this PR is merged, I will also remove the codecov branch protection from
v2-release
(but keep it onmain
).Additional Changes
There's some additional codecov related cleanup we need to do so might as well. They are explained as review comments.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license