Closed iliapolo closed 21 hours ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 77.19%. Comparing base (
6b0b1e1
) to head (7663a56
). Report is 1 commits behind head on main.
Exemption from integ because unit tests cover the offending code.
AWS CLI does:
--profile
: credentials profile > config profile > no region--profile
: credentials default > config default > no regionNo region behaves as follows:
Traditionally, CDK has defaulted to us-east-1 in this case. I'm like 90% sure we used to do that to copy the AWS CLI, I wonder if they changed their behavior when migrating CLIv1 -> CLIv2
Also CDK traditionally had the behavior that if the profile doesn't have a region, we will take the region from the [default] profile, but apparently the CLI doesn't do that.
EDIT: Ohh, AWS CLIv2 now has a magic aws-global
region, that they default to.
draft until we sort our credentials priority
:arrow_right: PR build request submitted to test-main-pipeline
:arrow_left:
A maintainer must now check the pipeline and add the pr-linter/cli-integ-tested
label once the pipeline succeeds.
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).
Comments on closed issues and PRs are hard for our team to see. If you need help, please open a new issue that references this one.
We just didn't consider the shared credentials file as returned by the SDK when loading configuration.
Closes #32130.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license