Open gracelu0 opened 7 hours ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 77.19%. Comparing base (
bf103d5
) to head (e69ef68
). Report is 2 commits behind head on main.
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
Issue # (if applicable)
Tracking #31785
Reason for this change
Since the Kinesis Data Firehose Alpha module is in developer preview and contains the L2 construct for a Firehose Delivery Stream, we should make this upgrade from L1 to L2 now instead of in the future where we would need to add a V2 for this target (like for event targets, see https://github.com/aws/aws-cdk/pull/30189).
Description of changes
Replace CfnDeliveryStream with IDeliveryStream. The L1 uses
S3DestinationConfiguration
property whereas the L2 usesExtendedS3DestinationConfiguration
property (includes additional fields on top of S3DestinationConfiguration fields). According to https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-kinesisfirehose-deliverystream.html, "If you change the delivery stream destination from an Amazon S3 destination to an Amazon ES destination, update requires some interruptions."Description of how you validated changes
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license
BREAKING CHANGE: KinesisDataFirehosePutRecord scheduler target now accepts IDeliveryStream instead of CfnDeliveryStream.