feat(s3-deployment): add security groups

aws / aws-cdk

The AWS Cloud Development Kit is a framework for defining cloud infrastructure in code

https://aws.amazon.com/cdk

Apache License 2.0

11.68k stars 3.93k forks source link

feat(s3-deployment): add security groups #32155

Open obraafo opened 20 hours ago

obraafo commented 20 hours ago

expose securityGroups attribute of lambda underlying s3 bucket deployment to provide more control over connectivity rules

Issue # (if applicable) Closes #.

Reason for this change Provide more control over the network connectivity of lambda underlying s3 bucket deployment

Description of changes Expose securityGroups attribute of s3 bucket deployment lambda

Description of how you validated changes Added/updated unit tests.

Checklist

[x] My code adheres to the CONTRIBUTING GUIDE and DESIGN GUIDELINES

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

aws-cdk-automation commented 16 hours ago

The pull request linter fails with the following errors:

❌ Features must contain a change to an integration test file and the resulting snapshot.

PRs must pass status checks before we can provide a meaningful review.

If you would like to request an exemption from the status checks or clarification on feedback, please leave a comment on this PR containing Exemption Request and/or Clarification Request.

aws-cdk-automation commented 16 hours ago

AWS CodeBuild CI Report

CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
Commit ID: d1e953578f74b152ae70c5487330be3ab8937cd5
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository