search

aws / aws-cdk

The AWS Cloud Development Kit is a framework for defining cloud infrastructure in code
https://aws.amazon.com/cdk
Apache License 2.0
11.65k stars 3.91k forks source link

[aws-eks] Modify the BlockDeviceMappings in eks.Cluster.addCapacity #3815

Closed abelmokadem closed 4 years ago

abelmokadem commented 5 years ago

:rocket: Feature Request

General Information

Description

Similar to https://github.com/aws/aws-cdk/issues/3620 Provide an option to specify the BlockDeviceMappings when adding an autoscaling group to the cluster.

Proposed Solution

Add BlockDeviceMapping to CapacityOptions.

Environment

Other information

SomayaB commented 5 years ago

Hi @abelmokadem, thanks for submitting this request. We would really appreciate it if you submitted a PR on this. 👍

abelmokadem commented 5 years ago

@eladb I see that this can be approached in different ways. I think the simplest would be to move blockDevices from AutoScalingGroupProps to CommonAutoScalingGroupProps? Is there any argument against this?

abelmokadem commented 4 years ago

https://github.com/aws/aws-cdk/pull/7291 I think this closes the issue.