search

aws / aws-cdk

The AWS Cloud Development Kit is a framework for defining cloud infrastructure in code
https://aws.amazon.com/cdk
Apache License 2.0
11.68k stars 3.93k forks source link

@aws-cdk/aws-datapipeline.CfnPipeline don't need to require `parameterObjects` #6711

Closed ufoo68 closed 4 years ago

ufoo68 commented 4 years ago

@aws-cdk/aws-datapipeline.CfnPipeline don't need parameterObjects

I think @aws-cdk/aws-datapipeline.CfnPipeline on CfnPipelineProps, parameterObjects is not required and pipelineObjects is required (if pipelineObjects is empty, cdk-deploy cause an error).

Because, aws-cdk able to define parameters using programing language(TypeScript etc..)

iliapolo commented 4 years ago

Hi @ufoo68.

The code you are referring to is auto generated from the CloudFormation specifications. You can see in the docs that:

You say there is an error when pipelineObjects is not specified, can you share the error and the code you used to deploy?

Thanks

github-actions[bot] commented 4 years ago

This issue has not received a response in a while. If you want to keep this issue open, please leave a comment below and auto-close will be canceled.

ufoo68 commented 4 years ago

Sorry, it is a not bug. This issue is just my option. CloudFormation on the doc specify parameterObjects is required, so parameterObjects is not nullable on aws-cdk. I basically do not use parameterObjects for develop the datapipeline using aws-cdk.

However, I understand that this library is based on cloudformation docs. I close this issue