aws / aws-cdk

The AWS Cloud Development Kit is a framework for defining cloud infrastructure in code
https://aws.amazon.com/cdk
Apache License 2.0
11.36k stars 3.77k forks source link

[route53] Support for health checks #9481

Open justin8 opened 3 years ago

justin8 commented 3 years ago

Currently the only way to define a health check or even to enable health checks for alias targets appears to be using Cfn resources instead of the higher level constructs.

Use Case

Route53 health checks are commonly used for multi-region architectures, and not being able to create them is a little limiting

Proposed Solution

Other


This is a :rocket: Feature Request

shivlaks commented 3 years ago

@justin8 I agree this is a pretty important missing feature. marking it as a p1 to help us prioritize getting it implemented and added in.

elhedran commented 3 years ago

Trying to work around this open ticket... not sure this is right though. Deployment seems to get stuck.


import { determineFullyQualifiedDomainName } from '@aws-cdk/aws-route53/lib/util'

// ...

const alias = new route53_targets.ApiGatewayv2DomainProperties(
    domainName.regionalDomainName, domainName.regionalHostedZoneId
)
const target = route53.RecordTarget.fromAlias(alias)

// latency based routing with health check
const gwStack = core.Stack.of(gw)
const healthCheck = new route53.CfnHealthCheck(this, 'healthCheck', {
    healthCheckConfig: {
        fullyQualifiedDomainName:
            `${gw.apiId}.execute-api.${gwStack.region}.${gwStack.urlSuffix}`,
        type: 'HTTPS',
        measureLatency: true
    }
})

new route53.CfnRecordSet(this, 'aRecordSet', {
    aliasTarget: {
        dnsName: domainName.regionalDomainName,
        hostedZoneId: domainName.regionalHostedZoneId,
        evaluateTargetHealth: true
    },
    name: determineFullyQualifiedDomainName(siteName, hostedZone),
    hostedZoneId: hostedZone.hostedZoneId,
    resourceRecords: target.values,
    type: route53.RecordType.A,
    region: gwStack.region,
    setIdentifier: id,
    healthCheckId: healthCheck.attrHealthCheckId
})

I'll update if I work out something better, but wanted to put what I had so far down given this has been open a while now.

This seems to work on a fresh push of a stack... still not sure on the update path. Taking the long game this time and giving the updated stack as much time as it needs (e.g. hours if need be)

Fitmavincent commented 2 years ago

Before this feature is available in the new release, do we have any way to associate a Cloudwatch Alarm with the Route53 Health Check in CDK?

OGoodness commented 2 years ago

Any update on this?

pflorek commented 1 year ago

Here is a small custom construct that should work with the higher level RecordSet. Supports Endpoint, Alarm and Calculated health checks. Has method to retrieve metrics for CloudWatch Alarms and methods to configure failover.

cdk-route53-health-check diagram

github-actions[bot] commented 3 weeks ago

This issue has received a significant amount of attention so we are automatically upgrading its priority. A member of the community will see the re-prioritization and provide an update on the issue.

wladyslawczyzewski commented 1 week ago

for those who are waiting for this: I have already opened the PR for alias records health checks and now I'm also working on regular health checks expecting the PR to be ready in a few days 🤞

wladyslawczyzewski commented 4 days ago

two PRs are waiting for review & merge – first one for alias target health evaluation & second one for AWS::Route53::HealthCheck resources