aws / aws-cdk

The AWS Cloud Development Kit is a framework for defining cloud infrastructure in code
https://aws.amazon.com/cdk
Apache License 2.0
11.66k stars 3.92k forks source link

[cdk-pipelines/core] Give assets a display name #9628

Open rix0rrr opened 4 years ago

rix0rrr commented 4 years ago

During cdk deploy and in the pipeline we now have no good way of showing the asset, just a hash.

Much friendlier to users if we should show a display name.


This is a :rocket: Feature Request

bobmoff commented 3 years ago

Did this feature die ?

It is a bit confusing to have this.. CleanShot 2021-10-21 at 15 05 27

.. would be awesome to be able to add display name.

bodokaiser commented 2 years ago

@rix0rrr any updates on this issue?

pfried commented 2 years ago

image

Is there any way (right now) to get better file asset naming?

clairemr commented 2 years ago

+1 feature request, this would be really useful

sonnenhaft commented 2 years ago

+1

jordanivy commented 2 years ago

+1

martijnburger commented 2 years ago

+1

droewe-reply commented 2 years ago

+1

SQPferrer commented 2 years ago

+1

siggi84 commented 2 years ago

+1

github-actions[bot] commented 2 years ago

This issue has received a significant amount of attention so we are automatically upgrading its priority. A member of the community will see the re-prioritization and provide an update on the issue.

KevinToala commented 2 years ago

+1

thedevopsguyblog commented 2 years ago

+1

jvjfranca commented 2 years ago

+1

ustulation commented 1 year ago

ping... updates pls?

joshdirkx commented 1 year ago

+1

mccauleyp commented 1 year ago

+1

sgates commented 1 year ago

+1

roey-navina commented 1 year ago

+1

danno-s commented 1 year ago

I'd be happy to give implementing this a try. From looking at the code, this would require adding a new field to StackAsset to contain a user-defined name and setting the pipeline's graph node id to it. Something like this:

// In pipeline-graph.ts
// Inside PipelineGraph.publishAsset
const id = stackAsset.assetName ?? stackAsset.assetType === AssetType.FILE
        ? (this.singlePublisher ? 'FileAsset' : `FileAsset${++this._fileAssetCtr}`)
        : (this.singlePublisher ? 'DockerAsset' : `DockerAsset${++this._dockerAssetCtr}`);

As far as I can tell, this would require modifying the schemas in the cloud-assembly-schema package and persisting these names in the asset manifest. With those then we can use them to populate the new field in the StackAsset. However I haven't been able to find where the manifest objects are built before they are persisted.

Does this implementation plan sound reasonable? I'd like some feedback from more experienced people in this project.

nick-benyo commented 1 year ago

Please add?

eliecer2000 commented 1 year ago

image

Is there any way (right now) to get better file asset naming?

Is it possible to group codebuild projects into one?

I say this because I would like a single project that is sending the assets file.

thank you,

Chrisjw42 commented 1 year ago

+1

Belair34 commented 1 year ago

+9 from my team. This would be quite nice!

davidmjames commented 1 year ago

Another upvote from my team as well.

avishmehta commented 1 year ago

+1

jcorey-envative commented 1 year ago

+1

dinesh-madhav commented 1 year ago

+1 looking to either hide the FileAsset in the pipeline or give meaningful names. If anyone knows how to do the former, it would help me a lot. Thanks

ilyash-b commented 1 year ago

+1

ustulation commented 1 year ago

I might be misremembering but I read somewhere that the tasks in this repo get prioritised based on upvotes on the original (first) post (and not on the progression of the comments). So hopefully everyone +1-ing in the replies are also +1-ing the original post too.

craigbroadman commented 1 year ago

+1

hakimbho commented 1 year ago

+1

enheit commented 9 months ago

+1

ozerbiber commented 8 months ago

+1

RickKrause commented 2 months ago

+1

melgard commented 1 month ago

+1

LawrenceStanton commented 1 month ago

+1

yasas-mintpay commented 4 days ago

+1