search

aws / aws-cli

Universal Command Line Interface for Amazon Web Services
Other
15.57k stars 4.13k forks source link

Please support generation of pre-signed URLs for S3 other than GET #3050

Open hoegertn opened 6 years ago

hoegertn commented 6 years ago

Support other methods and extra parameters for the generation of pre-signed URLs

joguSD commented 6 years ago

Marking as a feature request. We have the functionality in boto3 it just needs to be exposed as a command on the CLI.

ASayre commented 6 years ago

Good Morning!

We're closing this issue here on GitHub, as part of our migration to UserVoice for feature requests involving the AWS CLI.

This will let us get the most important features to you, by making it easier to search for and show support for the features you care the most about, without diluting the conversation with bug reports.

As a quick UserVoice primer (if not already familiar): after an idea is posted, people can vote on the ideas, and the product team will be responding directly to the most popular suggestions.

We’ve imported existing feature requests from GitHub - Search for this issue there!

And don't worry, this issue will still exist on GitHub for posterity's sake. As it’s a text-only import of the original post into UserVoice, we’ll still be keeping in mind the comments and discussion that already exist here on the GitHub issue.

GitHub will remain the channel for reporting bugs.

Once again, this issue can now be found by searching for the title on: https://aws.uservoice.com/forums/598381-aws-command-line-interface

-The AWS SDKs & Tools Team

jamesls commented 6 years ago

Based on community feedback, we have decided to return feature requests to GitHub issues.

raymyers commented 5 years ago

This PR by @max6746 adds this option: https://github.com/aws/aws-cli/pull/3979

github-actions[bot] commented 4 years ago

Greetings! It looks like this issue hasn’t been active in longer than one year. We encourage you to check if this is still an issue in the latest release. Because it has been longer than one year since the last update on this, and in the absence of more information, we will be closing this issue soon. If you find that this is still a problem, please feel free to provide a comment to prevent automatic closure, or if the issue is already closed, please feel free to reopen it.

stealthycoin commented 2 years ago

For the design of this feature I think we want to go with a multiple-subcommand approach. This would keep the argument namespaces for each operation separate, so they can be changed independently if need be.

For example:

aws presign-get ... (aliased to aws presign ...)
aws presign-put ...
aws presign-post ...

This would also aid in discovery, since at the autocomplete level if you type aws s3 presign its going to give you 3 autocomplete options for the supported operations.

G-Rath commented 2 years ago

@stealthycoin that design seems fine to me - what's the next steps towards getting this to a point where someone can work on it?

(I'm personally interested and willing to give it a crack, but Python isn't my strong suite so if anyone else wants to have a crack, go for it)

justindho commented 2 years ago

@G-Rath Since a maintainer has outlined a design and the issue has been marked as "contribution-ready", you can either make updates to #3979 or open up a new PR.

We have outlined a new contribution process in this proposal, so more information regarding process can be found within there.

G-Rath commented 2 years ago

I've opened #6993 implementing this