search

aws / aws-cli

Universal Command Line Interface for Amazon Web Services
Other
15.33k stars 4.08k forks source link

aws deploy push should not resolve file symlinks and should preserve directory symlinks #3393

Open et304383 opened 6 years ago

et304383 commented 6 years ago

As per the title. I expect my directory structure to be preserved when running aws deploy push

File symlinks are resolved to the actual file which is then copied to the symlink location, overwriting the symlink.

This is wrong.

Directory symlinks are ignored all together and are absent from the zip file.

This is wrong.

There is a recurring theme across the AWS tools of breaking symlink file structure. This is wrong.

jamesls commented 6 years ago

Thanks for the feedback, I think we can add an additional option to preserve symlinks similar to what we've done for s3 cp.

It really depends on what your use case is, but I can see it being useful both ways. Most tools have options for controlling how you want to handle symlinks, e.g cp -r doesn't copy symlinks but cp -R does. Seems reasonable that we'd have similar options.

stefanosAgelastos commented 4 years ago

I fell into this one too, is there any update?

github-actions[bot] commented 2 years ago

Greetings! It looks like this issue hasn’t been active in longer than one year. We encourage you to check if this is still an issue in the latest release. In the absence of more information, we will be closing this issue soon. If you find that this is still a problem, please feel free to provide a comment or upvote with a reaction on the initial post to prevent automatic closure. If the issue is already closed, please feel free to open a new one.

et304383 commented 2 years ago

I haven't seen any news of this being fixed.

gritzkoo commented 2 years ago

:thinking: I'ts a shame AWS does not provide a aws deploy push with option --preserve-symbolic-links os something like this, and keep this isso open since 2018...

JheregJAB commented 1 month ago

This has just caused us headaches.

Please consider this a +1 that aws deploy push should not be following symlinks and copying the content from the destination.