search

aws / aws-cli

Universal Command Line Interface for Amazon Web Services
Other
15.53k stars 4.13k forks source link

Support cloudformation artifact upload for cloudwatch synthetics canaries #5230

Closed Janpot closed 1 year ago

Janpot commented 4 years ago

Is your feature request related to a problem? Please describe.

Creating cloudwatch canaries with cloudformation requires uploading the test code prior to deploying.

Describe the solution you'd like

a similar solution as exists for lambda functions. Where the package command will upload local artifacts and update the template

Describe alternatives you've considered

Currently have to add extra ceremony to package, upload and generate a template

georgealton commented 4 years ago

Just took a quick look, and this could've been similar to Lambda Function resource, but the path to the Handler is defined in the Canary.Code object.

When packaging a Lambda function you set the value of Code to the local code path, which you can't do for Canary.Code because you'd lose the Handler reference. :(

kdaily commented 4 years ago

Hi @Janpot, @georgealton - I will notify the code owner for the CloudFormation package and deploy about this request and the associated PR. Thanks!

jk2l commented 3 years ago

@kdaily hi any update regarding this new feature?

aBurmeseDev commented 1 year ago

Thank you for the PR submission. Upon team discussion, we decided that internal discussions are needed with other SDK teams to keep consistency between SDKs. With that said, we might consider implementing this in the cross-SDK approach in the future and close this for now.

github-actions[bot] commented 1 year ago

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see. If you need more assistance, please open a new issue that references this one. If you wish to keep having a conversation with other community members under this issue feel free to do so.