search

aws / aws-cli

Universal Command Line Interface for Amazon Web Services
Other
15.11k stars 4.01k forks source link

Add in CodeArtifact tool flags to modify login behaviour #6634

Open whardier opened 2 years ago

whardier commented 2 years ago

Is your feature request related to a problem? Please describe. Pip and other CodeArtifact login tools need to modify login behaviour through the use of flags. Immediate use case is to alter which configuration setting is used with pip tool in order to avoid pulling through codeartifact upstreams (they are problematic) as well as speed up installation process (codeartifact is also slow)

Describe the solution you'd like I've provided PR #6633 to best describe the solution. Allow for --flags and provide some fairly generic choices.

Describe alternatives you've considered using --dry-run and sed to alter the command.. this is not a secure approach.

Additional context Let's speed up build/deploy and make devs lives a smidge easier when utilizing CodeArtifact.

kdaily commented 2 years ago

Hi @whardier,

Thanks for your post and the pull request. The CodeArtifact commands for the AWS CLI are maintained by the CodeArtifact team. I'll let them know about this suggestion. I'm not familiar with how this command works. Having an example of what you do now (with --dry-run and sed) and how your proposed change works to solve this would be helpful.

I can't provide a timeframe when the CodeArtifact team will be able to review, but I'll update when I hear something.

github-actions[bot] commented 2 years ago

Greetings! It looks like this issue hasn’t been active in longer than five days. We encourage you to check if this is still an issue in the latest release. In the absence of more information, we will be closing this issue soon. If you find that this is still a problem, please feel free to provide a comment or upvote with a reaction on the initial post to prevent automatic closure. If the issue is already closed, please feel free to open a new one.

whardier commented 2 years ago

Hmm. The close out process seems sub-optimal.

stealthycoin commented 2 years ago

Yea sorry about that. I'm going to re-open it. We have a new process for prioritizing contributions to review https://github.com/aws/aws-cli/pull/6828 detailing improvements to the contributing process. So I will be re-opening the issue for tracking interest, and marking the PR as draft until the criteria in the new process is met.

tim-finnigan commented 1 week ago

Thanks for your patience, it looks like this fell off of our radar. I'll try reaching out to the CodeArtifact team again to review this and share their feedback.