search

aws / aws-cli

Universal Command Line Interface for Amazon Web Services
Other
15.09k stars 4.01k forks source link

Bump the ceiling for botocore memory leak tests to 15 MiB #8744

Closed AdamWill closed 2 weeks ago

AdamWill commented 2 weeks ago

Issue #, if available:

Description of changes: See https://github.com/boto/botocore/issues/3205 for the background on this. In rebuilding awscli2 for Python 3.13 in Fedora Rawhide, we found that two of these tests fail because they now top out around 11MiB of memory usage, rather than around 1.6MiB. We don't understand why this is yet, but it's not a memory leak, so bumping the ceiling seems appropriate. I'm sending this upstream so I have a reference for the downstream package and to raise awareness of the issue, but the correct fix may be something else.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

tim-finnigan commented 2 weeks ago

Thanks for this PR — I just commented on the issue you opened providing more context. After discussing with the team we decided to close this PR as more research is required into the underlying issue, but please refer to https://github.com/boto/botocore/pull/3185 for further discussion around memory usage and testing in Python 3.13.