search

aws / aws-cli

Universal Command Line Interface for Amazon Web Services
Other
15.6k stars 4.14k forks source link

S3 path should be virtual-hosted–style #8841

Open yukikgiants opened 3 months ago

yukikgiants commented 3 months ago

Describe the issue

The example uses Path-style URL for the S3 object, which is not recommended and should be updated to use the Virtual-hosted-style (as documented here)

Links

https://github.com/aws/aws-cli/blob/develop/awscli/examples/servicecatalog/create-provisioning-artifact.rst?plain=1#L16

tim-finnigan commented 3 months ago

Thanks for reaching out — we can update the CLI examples, but first I think the ServiceCatalog needs to update their API documentation for CreateProvisioningArtifact, which references the path-style. So I think once they document virtual-style then we can reflect that in the example. I reached out to that team for review and we can revisit this.