search

aws / aws-cloud-map-mcs-controller-for-k8s

K8s controller implementing Multi-Cluster Services API based on AWS Cloud Map.
https://aws.amazon.com/blogs/opensource/kubernetes-multi-cluster-service-discovery-using-open-source-aws-cloud-map-mcs-controller/
Apache License 2.0
88 stars 28 forks source link

Add deletecollection verb. #248

Closed runakash closed 1 year ago

runakash commented 1 year ago

Issue #, if available: Fixes https://github.com/aws/aws-cloud-map-mcs-controller-for-k8s/issues/225

Description of changes: Add deletecollection verb. To fix the error encountered with k8s DeleteAllOf operation on endpointslices.discovery.k8s.io.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

codecov-commenter commented 1 year ago

Codecov Report

Merging #248 (02e7184) into main (4dc8b4d) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #248   +/-   ##
=======================================
  Coverage   71.47%   71.47%           
=======================================
  Files          17       17           
  Lines        1697     1697           
=======================================
  Hits         1213     1213           
  Misses        406      406           
  Partials       78       78
Impacted Files Coverage Δ
...kg/controllers/multicluster/cloudmap_controller.go 52.86% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4dc8b4d...02e7184. Read the comment docs.