search

aws / aws-codebuild-docker-images

Official AWS CodeBuild repository for managed Docker images http://docs.aws.amazon.com/codebuild/latest/userguide/build-env-ref.html
Other
1.11k stars 971 forks source link

Add Go 1.22 support #711

Closed driverpt closed 4 months ago

driverpt commented 5 months ago

Issue #701 Description of changes: Add Go 1.22 Latest version

Important Notes goenv now uses latest available patch version on global command. https://github.com/go-nv/goenv/issues/296

srgoni commented 5 months ago

This PR doesn't actually add Go 1.22 support. The commands you're executing can also be called as normal build tasks. They won't work if a CodeBuild project is configured without internet access.

To add Go 1.22, your PR needs to modify the Dockerfiles so actually download and install Go 1.22 during the container build phase.

driverpt commented 5 months ago

Thank you for the feedback. But if we modify the Dockerfiles, how do we ensure that it always installs latest minor version?

srgoni commented 5 months ago

It doesn't, and I believe that's also not what AWS guarantees with the CodeBuild images.

If you'd like to use the images that way, why not just call goenv install x.y.z from an install task in your buildspec? That shouldn't require modifying the images.

subinataws commented 4 months ago

Thanks for the contribution. Go 1.22 support is available in Amazon Linux (5.0) and Ubuntu (7.0) images for x86. Arm container image will get this support in an upcoming release. Resolving, as CodeBuild will be adding support for these runtimes.