search

aws / aws-codebuild-docker-images

Official AWS CodeBuild repository for managed Docker images http://docs.aws.amazon.com/codebuild/latest/userguide/build-env-ref.html
Other
1.12k stars 977 forks source link

Should images ship with `docker-credential-ecr-login` pre-installed and configured? #743

Open moltar opened 1 month ago

moltar commented 1 month ago

https://github.com/awslabs/amazon-ecr-credential-helper

It seems like a massive improvement over the classic:

aws ecr get-login-password --region=foo | \
  docker login --username AWS --password-stdin repository-uri
jplock commented 1 month ago

It looks like the package is already included but needs to be configured.

moltar commented 1 month ago

Hm, that's interesting because I don't see it on the aws/codebuild/standard:7.0 image:

#2 ERROR: error getting credentials - err: exec: "docker-credential-ecr-login": executable file not found in $PATH, out: ``