search

aws / aws-codedeploy-agent

Host Agent for AWS CodeDeploy
https://aws.amazon.com/codedeploy
Apache License 2.0
329 stars 187 forks source link

Add support to Ruby version 2.6 #217

Closed mujz closed 5 years ago

mujz commented 5 years ago

Issue #, if available: #214

Description of changes: Add support for Ruby 2.6 to the install script

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

I already tested this and it seems to work just fine.

coveralls commented 5 years ago

Coverage Status

Coverage remained the same at 91.679% when pulling daba76931c14a6c4a4b3a1c80a632ec44437c44e on mujz:patch-1 into 7a58ba993f7b92a4012d12ee4573d50bd19a812d on aws:master.

mujz commented 5 years ago

Ping. Can an admin please look at this? It's very simple @rohkat-aws @pmzara @annamataws

inductor commented 5 years ago

https://github.com/aws/aws-codedeploy-agent/pull/196 This as well :(

mujz commented 5 years ago

Seems like nobody is maintaining this repo anymore :(

rohkat-aws commented 5 years ago

the ruby 2.6 will have to be tested internally before we release it as a supported ruby version @mujz

mujz commented 5 years ago

Great to hear from you @rohkat-aws. Thanks for your input! That makes sense. Would you be able to provide any input on how long it might take for the internal testing? I understand that it's hard to give time estimates, so I won't hold you to it. Just knowing whether this is something that somebody is working on or not is all I'm looking to know here.

mujz commented 5 years ago

@rohkat-aws any update on this? Last I heard from you was about 2 months ago.