search

aws / aws-connected-device-framework

Apache License 2.0
62 stars 38 forks source link

Asset Library Supports Regex Search #167

Open anish-kunduru opened 1 year ago

anish-kunduru commented 1 year ago

Aws Connected Device Framework Affected Module(s):

**I'm submitting a ...**

Description:

With the introduction of TinkerPop 3.6.x, it is now possible to search via regex, which should make it much easier to find matches. The request is to support this functionality by adding updating the minimum cluster version to 1.2.1.0.R2, which includes TinkerPop 3.6 and updating the relevant CDF code to take regex input as an argument.

Current behavior:

CDF supports the ability to search, but doesn't support regex capability.

Expected behavior:

Steps to reproduce:

Additional Information: Currently WIP on a branch in my fork.

canavandl commented 1 year ago

Hi @anish-kunduru - Do you mind opening a PR of your WIP branch and we can discuss what's required to finish it/get it merged?

joysl commented 1 year ago

Hi @canavandl , In order for regex to work NeptuneDB engine version has to be 1.2.1.0: https://docs.aws.amazon.com/neptune/latest/userguide/engine-releases-1.2.1.0.html However if we deploy CDF with Asset Library the Neptune version deployed is 1.2.0.2 I'm working on a feature, where version can be specifies in addition to the instance family. CC: @jaychung-aws https://github.com/aws/aws-connected-device-framework/issues/170

joysl commented 1 year ago

PR is now ready: https://github.com/aws/aws-connected-device-framework/pull/179 CC: @anish-kunduru @jaychung-aws @canavandl

joysl commented 12 months ago

Verified that this works E2E with a minor change on gremlin version[updated] just make sure https://github.com/aws/aws-connected-device-framework/pull/179 is merged first

CC: @jaychung-aws thanks for figuring out the issue

anish-kunduru commented 12 months ago

@canavandl I was out on vacation, so @joysl picked this up for me.

Does it make sense for us to combine Joyson's PR into this feature and merge both at the same time? We'll have to rebase to pull in the latest changes from master and I'd like to avoid doing that multiple times.