search

aws / aws-dax-go

AWS DAX SDK for the Go programming language. https://aws.amazon.com/dynamodb/dax
Apache License 2.0
47 stars 49 forks source link

Dax client can not be cast to dynamodbiface.dynamodbapi after 1.25.40 #21

Closed ardaguclu closed 4 years ago

ardaguclu commented 4 years ago

In the service package, there is;

var _ dynamodbiface.DynamoDBAPI = (*Dax)(nil)

After aws-sdk-go 1.25.40 version has been released, Dax started not being casted to dynamodbiface.dynamodbapi anymore.

For that reason, I opened PR for this issue;

https://github.com/aws/aws-dax-go/pull/20

VasilyFomin commented 4 years ago

Thank you for the contribution, I merged the PR.

cfortuner commented 4 years ago

I think I'm still seeing issues for this ? *Dax does not implement dynamodbiface.DynamoDBAPI (missing DescribeContributorInsights method)

VasilyFomin commented 4 years ago

Thanks for reporting, we're going to prioritize the fix.

It's caused by Release v1.25.43 (2019-11-26) which happened yesterday.

ezerozen commented 4 years ago

I have the same issue with github.com/aws/aws-dax-go v1.1.4 and github.com/aws/aws-sdk-go v1.28.0

aws-dax-go@v1.1.4/dax/service.go:129:5: cannot use (Dax)(nil) (type Dax) as type dynamodbiface.DynamoDBAPI in assignment: *Dax does not implement dynamodbiface.DynamoDBAPI (missing DescribeContributorInsights method)

dragon9786 commented 4 years ago

It seems like the interface requirements were satisfied with this commit: https://github.com/aws/aws-dax-go/commit/f18aceacc28942624e5b48d6e7c1538d45956388#diff-8576d07acff0ae4d08c05392d7535ae3 on December 2nd 2019.

However the latest release v1.1.4 was from November 13 2019

cc: @VasilyFomin