search

aws / aws-dax-go

AWS DAX SDK for the Go programming language. https://aws.amazon.com/dynamodb/dax
Apache License 2.0
47 stars 48 forks source link

Separate PosInt and NegInt #29

Closed nowij3 closed 3 years ago

nowij3 commented 3 years ago

fix the problem of converting uint64 value into negative int64

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

kevinchristen commented 3 years ago

Thanks for pointing out this problem. The pull request didn't deal with overflowing the int64 by CBOR negative integers with the high bit set, so I took a slightly different approach, as well as adding some tests, but I would not have known to do that without your pull request.