search

aws / aws-dax-go

AWS DAX SDK for the Go programming language. https://aws.amazon.com/dynamodb/dax
Apache License 2.0
47 stars 49 forks source link

feat: update to new Dynamo transaction limit #41

Closed aaguiarz closed 1 year ago

aaguiarz commented 1 year ago

Issue #, if available:

https://github.com/aws/aws-dax-go/issues/40

Description of changes: I updated the maxWriteBatchSize to 100, to align with new DynamoDB limits https://aws.amazon.com/about-aws/whats-new/2022/09/amazon-dynamodb-supports-100-actions-per-transaction/

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

miparnisari commented 1 year ago

@sumitsa-amazon can you take a look at this? Thanks :)

sumitsa-amazon commented 1 year ago

Hi,

Thank you for contributing to DAX Go SDK.

I see that the PR increases the limit of batch size from 25 to 100 for the BatchWriteItem API. For BatchWriteItem the limit of number of operations is still set to 25 operations per request - ref. The relaxation in limit from 25 operations to 100 operations is only applicable for transact APIs.

miparnisari commented 1 year ago

Ohh that's a good point. Are you saying that if we attempt a TransactWrite call with 100 items, it should work? I need to try that out...

miparnisari commented 1 year ago

Ohh that's a good point. Are you saying that if we attempt a TransactWrite call with 100 items, it should work? I need to try that out...

It does work!

sumitsa-amazon commented 1 year ago

Thank you for confirmation. I'll close this PR.