search

aws / aws-dax-go

AWS DAX SDK for the Go programming language. https://aws.amazon.com/dynamodb/dax
Apache License 2.0
47 stars 48 forks source link

use aws-sdk-go-v2 #43

Open shamaton opened 1 year ago

shamaton commented 1 year ago

Issue #, if available:

2

Description of changes:

use aws-sdk-go-v2 in the entire code. If you have any questions, please feel free to ask.

Summary of the changes

Although there are numerous changes in the code, I have made the following modifications:

Verification

I have created a validation repository to confirm if the changed code is actually usable. https://github.com/shamaton/aws-dax-go-v2-test

The future of this pull request

I think there are the following options:

  1. Merge this pull request into the master branch.
  2. Merge the changes of this pull request into another branch, such as v2, and proceed with the operation.
  3. Create a separate repository to make it usable, for example, aws/aws-dax-go-v2.
  4. Reject this pull request (unfortunate decision).

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

shamaton commented 1 year ago

Any comments or reviews from aws staff?

anudeeb commented 1 year ago

@shamaton Thank you for raising the PR. We are currently reviewing it and will get back to you soon.

miparnisari commented 11 months ago

Question: since there is no way of testing DAX locally, has this PR been tested against an actual DAX cluster?

shamaton commented 11 months ago

@miparnisari

Question: since there is no way of testing DAX locally, has this PR been tested against an actual DAX cluster?

Yes. I created a validation repository to confirm if the changed code is actually usable. https://github.com/shamaton/aws-dax-go-v2-test

Please, see verfication part of summary.

bsandeepan commented 11 months ago

Hi, if this PR gets approved, by when can we expect these changes ready for production usage?

shamaton commented 9 months ago

Hi, is status reviewing now?

srri commented 8 months ago

Bumping interest on this PR. Lots of us are waiting for a SDK v2 version of this DAX client. Feels like it's been abandoned..

ngjmcdonald commented 6 months ago

Adding another voice, hoping to get this SDK upgraded to the new version in the new year! Echoing the previous comment it feels like it's been abandoned but DAX is still encouraged as the cache for DynamoDB

Joao-Pedro-MB commented 5 months ago

Hello everyone. Any updates on this PR? I have been studying the Shamaton changes, and they are quite solid. I was able to make it work very easily, even with a newer Go version in go.mod.

vincent-ogury commented 2 weeks ago

Hello. This PR has more than 1 year. The project seems abandoned. Do you think that would be a good idea to fork the project and implement v2 ?

For example using @shamaton repository as the new one ?