search

aws / aws-dotnet-deploy

Opinionated tooling that simplifies deployment of .NET applications to AWS.
https://aws.github.io/aws-dotnet-deploy/
Apache License 2.0
138 stars 32 forks source link

fix: remove auto self-contained build for .NET 8 beanstalk deployments #847

Closed philasmar closed 1 month ago

philasmar commented 1 month ago

Issue #, if available: DOTNET-7212

Description of changes: In order to support deploying .NET8 apps on Beanstalk prior to Beanstalk adding .NET8 support, we had to force .NET8 apps to be self-contained in order to allow for Beanstalk support. Beanstalk has since added .NET8 support, so this PR removes this restriction to allow .NET8 apps to be deployed to Beanstalk not as self-contained apps.

This PR also improves the sorting of Beanstalk platforms to show the latest .NET versions first.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 91.30435% with 6 lines in your changes missing coverage. Please review.

Project coverage is 62.39%. Comparing base (db9ec45) to head (746a0e7). Report is 1 commits behind head on dev.

Files Patch % Lines
...WS.Deploy.Orchestration/DeploymentBundleHandler.cs 86.11% 1 Missing and 4 partials :warning:
...WS.Deploy.Orchestration/Data/AWSResourceQueryer.cs 95.83% 0 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev #847 +/- ## ========================================== + Coverage 61.93% 62.39% +0.45% ========================================== Files 279 279 Lines 10850 10900 +50 Branches 1496 1513 +17 ========================================== + Hits 6720 6801 +81 + Misses 3598 3563 -35 - Partials 532 536 +4 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

philasmar commented 1 month ago

Add a platform version check for the version that added .NET8. If a user is redeploying we shouldn't break them.