aws / aws-dotnet-deploy

Opinionated tooling that simplifies deployment of .NET applications to AWS.
https://aws.github.io/aws-dotnet-deploy/
Apache License 2.0
140 stars 32 forks source link

fix: Generated CDK projects referencing version of System.Text.Json #850

Closed normj closed 3 months ago

normj commented 3 months ago

Issue #, if available: https://github.com/aws/aws-toolkit-visual-studio/issues/462

Description of changes: The generated CDK projects have TreatWarningsAsErrors as true which makes deployments start failing immediately when a dependency has a listed vulnerability. In this case System.Text.Json has a listed failure which causes the generated CDK project fail to build preventing deployment.

This PR updates the version of System.Text.Json which was actually coming in as a transitive dependency from Microsoft.Extensions.Configuration.Json. It also removes the TreatWarningsAsErrors property from the generated projects because we have no control when a package might be listed as vulnerable and we don't one deployments to just start failing when that happens.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 62.35%. Comparing base (b390e37) to head (e2ed984). Report is 2 commits behind head on dev.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev #850 +/- ## ======================================= Coverage 62.35% 62.35% ======================================= Files 279 279 Lines 10900 10900 Branches 1513 1513 ======================================= Hits 6797 6797 Misses 3566 3566 Partials 537 537 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.