search

aws / aws-dynamodb-encryption-python

Amazon DynamoDB Encryption Client for Python
Apache License 2.0
96 stars 57 forks source link

Wrong formatting in the deprecated python warning #524

Open ShubhamChaturvedi7 opened 1 year ago

ShubhamChaturvedi7 commented 1 year ago

Security issue notifications

If you discover a potential security issue in the Amazon DynamoDB Encryption Client we ask that you notify AWS Security via our vulnerability reporting page. Please do not create a public GitHub issue.

Problem:

https://github.com/aws/aws-dynamodb-encryption-python/blob/35ee30aea5a93b4446677fdf1f14edc3ca3c0452/src/dynamodb_encryption_sdk/compatability.py#L39

The _minimumversion and date seem to have been swapped in the deprecated python warning.

Solution:

Putting the params["date"] before the minimum_version[0] should fix the issue.

Out of scope:

Is there anything the solution will intentionally NOT address?

mattsb42-aws commented 1 year ago

Since you don't support <3.6 anymore, you could also replace this with fstrings. ;)

khubaibalam2000 commented 1 year ago

Can I work on this issue?

bawejahritik commented 8 months ago

Is this issue still open?