aws / aws-eks-best-practices

A best practices guide for day 2 operations, including operational excellence, security, reliability, performance efficiency, and cost optimization.
https://aws.github.io/aws-eks-best-practices/
Other
2k stars 486 forks source link

Clarify EKS Control Plane Subnet Selection #416

Open blakeromano opened 10 months ago

blakeromano commented 10 months ago

Describe the problem The EKS Networking communication talks about best practices for Public/Private subnets however the documentation doesn't make the clarification this is really referring to the way to schedule workers not what Subnets are passed to EKS for the control plane.

The documentation should make it clear this is relating to the worker nodes not the control plane which is specified by the Subnets for the EKS Cluster and ideally should link to new documentation regarding cluster control plane subnet best practices.

References https://github.com/aws/aws-eks-best-practices/blob/master/content/networking/subnets/index.md#you-can-configure-vpc-and-subnets-in-three-different-ways

jicowan commented 10 months ago

There is a paragraph above the section you reference that says the following:

The nodes connect to the EKS control plane through (a) an EKS public endpoint or (b) a Cross-Account [elastic network interfaces](https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/using-eni.html) (X-ENI) managed by EKS. When a cluster is created, you need to specify at least two VPC subnets. EKS places a X-ENI in each subnet specified during cluster create (also called cluster subnets). The Kubernetes API server uses these Cross-Account ENIs to communicate with nodes deployed on the customer-managed cluster VPC subnets.

Is this not clear enough?

blakeromano commented 10 months ago

I think the wording of best practices for public/private subnets are the part that makes it unclear which it is referring to. If there was some sort of note or reference or something saying that Section is relating to worker nodes or something along those lines