aws / aws-elastic-beanstalk-cli

The EB CLI is a command line interface for Elastic Beanstalk that provides interactive commands that simplify creating, updating and monitoring environments from a local repository.
Apache License 2.0
161 stars 78 forks source link

Increase PyYAML limit as awscli #442

Closed mbonfoster closed 1 year ago

mbonfoster commented 1 year ago

Should fix #441

Description of changes: This PR updates PyYAML limit in order to match with awscli. https://github.com/aws/aws-cli/pull/8037

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

ahmaze commented 1 year ago

This is the related issue in pyyaml repo: https://github.com/yaml/pyyaml/issues/724

mbonfoster commented 1 year ago

@Mickeypeng any chance of reviewing/merging this PR?

justinpincar commented 1 year ago

Thank you for the fix! This issue is preventing us from deploying; would love to see this merged soon~

Mickeypeng commented 1 year ago

LGTM what do you think? @NihalM99

chenrui333 commented 1 year ago

actually found a dependency conflict with docker-compose v1

relates to https://github.com/docker/compose/issues/9114

raise an issue, https://github.com/aws/aws-elastic-beanstalk-cli/issues/448

mbonfoster commented 1 year ago

@Mickeypeng @NihalM99 updates? I think that merging this PR will help many people that's having issues with deployment. Of course it's also necessary to check the conflict with docker-compose that @chenrui333 is mentioning, but merging this PR will help on many other cases.

gabrielmontenegro-eye commented 1 year ago

Thank you on this effort guys. Just reinforcing that this issue is also preventing us from deploying an important hotfix.

Mickeypeng commented 1 year ago

Seems like the test failed to run because it was from branch in another repo. Let me pull a new PR for testing, and then I will merge this one.

Mickeypeng commented 1 year ago

https://github.com/aws/aws-elastic-beanstalk-cli/pull/449 Same changes passed tests. Merging now