aws / aws-encryption-sdk-java

AWS Encryption SDK
https://docs.aws.amazon.com/encryption-sdk/latest/developer-guide/introduction.html
Apache License 2.0
224 stars 123 forks source link

chore(JavaDocs): detail thread saftey of SDK Client Builders #2048

Closed texastony closed 1 week ago

texastony commented 1 month ago

Issue #, if available:

The AWS SDK for Java's Service Client builders are not thread safe. Crypto Tools customer's have reported odd, occasionally disruptive behavior when using them in a concurrent setting.

As such, Crypto Tools should make it clear how to set a KMS Client in a thread safe manner.

Which can be done via the Regional Client Supplier.

Additionally, we can improve on the Java Documentation to highlight that Builders are not thread safe, and that proper Builder suppliers MUST be used, or customers SHOULD use the alternative client configuration methods.

Description of changes:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Check any applicable: