search

aws / aws-extensions-for-dotnet-cli

Extensions to the dotnet CLI to simplify the process of building and publishing .NET Core applications to AWS services
Apache License 2.0
369 stars 86 forks source link

chore: Remove S3 buckets which are not used in test applications #242

Closed dscpinheiro closed 1 year ago

dscpinheiro commented 1 year ago

Description of changes: Remove S3 buckets which are missing encryption and versioning settings, but are not used at all in the test applications.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

ppittle commented 1 year ago

Just to triple check, will the Test Apps work if they don't have Upload Buckets?

Curious, would it be better to just turn on Encryption and Versioning for these buckets?

Something like

UploadsBucket:
    Type: AWS::S3::Bucket
    Properties:
       BucketEncryption:
          ServerSideEncryptionConfiguration:
               "EncryptionRole"
       VersioningConfiguration:
           Status: Enabled
dscpinheiro commented 1 year ago

Just to triple check, will the Test Apps work if they don't have Upload Buckets?

Curious, would it be better to just turn on Encryption and Versioning for these buckets?

Something like

UploadsBucket:
    Type: AWS::S3::Bucket
    Properties:
       BucketEncryption:
          ServerSideEncryptionConfiguration:
               "EncryptionRole"
       VersioningConfiguration:
           Status: Enabled

Yes, they should work (the buckets are not referenced in the test apps).