fix: secondary process crash

aws / aws-fpga

Official repository of the AWS EC2 FPGA Hardware and Software Development Kit

Other

1.51k stars 516 forks source link

fix: secondary process crash #588

Open pengjianzhang opened 1 year ago

pengjianzhang commented 1 year ago

the secondary process cannot memset spp_dev to zero.

kyyalama2 commented 1 year ago

Can you please elaborate, what the issue seen was (if its failing a particular use-case, seeing errors etc) and how the update fixes the issue. Thanks

pengjianzhang commented 1 year ago

I start a primary process and then a secondary process; the primary process crashes. The location of the crash is in the function spp_tx_process_status(), and the statement "uint32_t status = tx_chan->tx_info.tx_status->status" accesses address zero.

The reason is that the secondary process cleared this memory by function eth_spp_init(). The secondary process can only attach these data structures and cannot modify them. I put 'memset' after checking the process's type.

pengjianzhang commented 1 year ago

rx_chan was cleared