I believe CLIENT_USERNAME, CLIENT_PASSWORD etc should be optional like ota_demo_core_http and mqtt_demo_mutual_auth. Otherwise we get a false warning when configuring the build.
WARNING: ota_demo_core_mqtt missing definitions for macros: CLIENT_USERNAME, CLIENT_PASSWORD
To run ota_demo_core_mqtt, define required macros in ota_demo_core_mqtt/demo_config.h.
By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.
zhuang-hy
commented
2 years ago
Issue #, if available:
Description of changes:
I believe CLIENT_USERNAME, CLIENT_PASSWORD etc should be optional like ota_demo_core_http and mqtt_demo_mutual_auth. Otherwise we get a false warning when configuring the build.
By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.