search

aws / aws-iot-device-sdk-embedded-C

SDK for connecting to AWS IoT from a device using embedded C.
MIT License
974 stars 622 forks source link

fleet provisioning with csr demo support for using existing private key and to write certificate to disk #1877

Closed giuspen closed 10 months ago

giuspen commented 10 months ago

Issue #, if available:

Description of changes:

I added support in the fleet provisioning with csr demo for using an already existing private key instead of generating a new one (if defining EXISTING_PRIVATE_KEY_PATH) and to write the downloaded certificate to disk (if defining DOWNLOADED_CERT_WRITE_PATH)

By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.

Skptak commented 10 months ago

Hey @giuspen, thanks for submitting this update to the demo! These seem like useful changes for this demo! I'm reaching out to a team-member who's worked with this to see if they can provide a review

giuspen commented 10 months ago

Thanks @Skptak note for completeness that I would also like in future to optionally allow to save the private key to disk when generated in this demo, but that is blocked from the issue https://github.com/aws/aws-iot-device-sdk-embedded-C/issues/1878

giuspen commented 10 months ago

I see @paulbartell thanks for your review