search

aws / aws-iot-device-sdk-embedded-C

SDK for connecting to AWS IoT from a device using embedded C.
MIT License
974 stars 622 forks source link

HTTP demo S3 download added missing macro in ROOT_CA_CERT_PATH_S3 con… #1884

Closed giuspen closed 9 months ago

giuspen commented 9 months ago

…fig and allow other macros to be already defined from cmake

Issue #, if available:

Description of changes:

I think ROOT_CA_CERT_PATH_S3 should also be in demo_config.h for clarity and other macros consistently to other demos should be allowed to be already defined from cmake

By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.

chinglee-iot commented 9 months ago

Thank you for creating this pull request. I will look into this PR and discuss with you here.

chinglee-iot commented 9 months ago

@giuspen The macro ROOT_CA_CERT_PATH_S3 is supposed to be used when connecting to the S3 server. Can you also help to update the following line to use this macro in this PR? https://github.com/aws/aws-iot-device-sdk-embedded-C/blob/af6b6efc09d98dea8dadc3db1e2992b593abb104/demos/http/http_demo_s3_download/http_demo_s3_download.c#L945

giuspen commented 9 months ago

Sure thanks for your review @chinglee-iot