New HTTP demo to generate a pre-signed URL to an S3 object file

[giuspen]

New HTTP demo to generate a pre-signed URL to an S3 object file.

The setup is identical to the demo HTTP S3 download and in fact I implemented this based on that demo / starting from a duplication of demos/http/http_demo_s3_download.

By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.

[kstribrnAmzn]

Thank you for this contribution! I will review your PR today and send this out to the team for further review.

[kstribrnAmzn]

Do you intend for this demo to only generate the pre-signed URL? Or would you also like it to download the item using the pre-signed URL?

[kstribrnAmzn]

There is a lot of duplicated code between your demo and the download demo (which you based it off of). Would you mind refactoring some of these functions to a common location like this?

[giuspen]

Thanks for your review @kstribrnAmzn , I will push new commits with the requested changes. I didn't think about also downloading the object because there is already another demo that is doing exactly that - the http download from S3 multi threaded takes a presigned URL as an input

[kstribrnAmzn]

Thank you so much @giuspen! Looking forward to reviewing when you push the changes. Keeping pre-signed URL creation and download as separate demos works for me. It should be far simpler for a new user to understand.

[giuspen]

I addressed all the points of the review except for the refactoring to share code with the other demo, will do that in one of the next few days...

[giuspen]

@kstribrnAmzn I refactored most of the common code in a shared .h/.c please let me know your thoughts

[kstribrnAmzn]

I'll take a look later today. Thank you for taking the time to refactor this :)

[kstribrnAmzn]

On first pass I don't see anything troubling. I will make a more thorough review tomorrow morning with fresh eyes and see if I can fix the failing workflows (or can make suggestions for how you may).

Thank you for your hard work on this! Its really awesome to see how the refactor you did shrunk both demos by over 1k lines combined. I'd says that's a huge win :)

[kstribrnAmzn]

/bot run uncrustify

[kstribrnAmzn]

I've pushed a commit applying some fixes from the workflow failures. I doubt I've got them all so I may be applying a further commit.

[giuspen]

Thanks for your review @kstribrnAmzn I'm pretty busy for a couple of days but then I'll process your comments!

[giuspen]

@kstribrnAmzn thanks again for your work on my PR, I removed the unneeded code that you spotted and the leftover from copy/paste in the README

[kstribrnAmzn]

Merged. Thank you for your hard work on this one @giuspen 😄

[giuspen]

Cool, thanks to you @kstribrnAmzn take care ;)