Require only the necessary modules from crypto-js to optimize bundle

aws / aws-iot-device-sdk-js

SDK for connecting to AWS IoT from a device using JavaScript/Node.js

Apache License 2.0

964 stars 384 forks source link

Require only the necessary modules from crypto-js to optimize bundle #333

Closed dbradleyfl closed 4 years ago

dbradleyfl commented 4 years ago

Issue #, if available: The crypto-js module is currently 30% of this package when bundled. https://bundlephobia.com/result?p=aws-iot-device-sdk@2.2.4

Description of changes: Rather than requiring the entire crypto-js libary, this change requires just the specific components of crypto-js that are utilized.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

bretambrose commented 4 years ago

I'm not sure yet, but we may roll this together with another update so it might be delayed a few days.

dbradleyfl commented 4 years ago

@bretambrose I appreciate for the updates. I'm using my fork in the meantime.

bretambrose commented 4 years ago

Your PR has been merged and a new release is available in npm (2.2.6) Thanks for the contribution!