aws / aws-iot-device-sdk-js

SDK for connecting to AWS IoT from a device using JavaScript/Node.js
Apache License 2.0
965 stars 385 forks source link

device-example.js topics #398

Closed liunamz-aws closed 2 years ago

liunamz-aws commented 2 years ago

Confirm by changing [ ] to [x] below to ensure that it's a bug:

Describe the bug A clear and concise description of what the bug is. In https://github.com/aws/aws-iot-device-sdk-js/blob/master/examples/device-example.js, In line 63, topic_2 should be topic_1, and in line 67, topic_1 should be topic_2.

SDK version number

Platform/OS/Hardware/Device What are you running the sdk on? EC2 instance

To Reproduce (observed behavior) Steps to reproduce the behavior (please share code) https://docs.aws.amazon.com/iot/latest/developerguide/iot-quick-start.html#iot-quick-start-install-run

Expected behavior A clear and concise description of what you expected to happen.

Logs/output If applicable, add logs or error output.

REMEMBER TO SANITIZE YOUR PERSONAL INFO

Additional context Add any other context about the problem here.

bretambrose commented 2 years ago

I don't think the connection kit sample and device-example are the same thing nor should they behave the same. The device example for js v1 was set up with the intention that you run it twice, one run in each mode. Done this way, the two separate runs then communicate to each other. There wouldn't be a need for two separate modes if each mode just talked to its own subscription.

github-actions[bot] commented 2 years ago

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see. If you need more assistance, please either tag a team member or open a new issue that references this one. If you wish to keep having a conversation with other community members under this issue feel free to do so.

adamgruber commented 2 years ago

I don't think the connection kit sample and device-example are the same thing

@bretambrose In the current implementation, the connection kit runs the device-example.